Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak constant example in Shading language to avoid referring to reserved PI #10163

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Tweak constant example in Shading language to avoid referring to reserved PI #10163

merged 1 commit into from
Oct 29, 2024

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Oct 29, 2024

@Calinou Calinou added bug area:manual Issues and PRs related to the Manual/Tutorials section of the documentation topic:shaders cherrypick:4.3 labels Oct 29, 2024
@skyace65 skyace65 merged commit f512e1e into godotengine:master Oct 29, 2024
1 check passed
@skyace65
Copy link
Contributor

Thanks!

@Arnklit
Copy link
Contributor

Arnklit commented Oct 29, 2024

Thanks Hugo!

@tetrapod00
Copy link
Contributor

This one is a clear cherrypick as a bugfix. There's an unrelated whitespace change bundled along with it that can be ignored when cherrypicking.

@tetrapod00 tetrapod00 mentioned this pull request Nov 30, 2024
Merged
@tetrapod00
Copy link
Contributor

Cherrypicked to 4.3 in #10356.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AThousandShips AThousandShips AThousandShips approved these changes

@skyace65 skyace65 skyace65 approved these changes

Assignees
No one assigned
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation bug topic:shaders
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"const float PI" is no longer a valid line of code and should be removed from the docs
5 participants
@Calinou @skyace65 @Arnklit @tetrapod00 @AThousandShips